• 0 Posts
  • 79 Comments
Joined 1 year ago
cake
Cake day: June 26th, 2023

help-circle




  • I had several tests at the beginning of the script. These tests define the “low-level” functions based the capability of the shell. To test new features I “simply” ran all the necessary commands on the test environments (bash, busybox, toybox+mksh).

    The script would error out if some necessary capability was missing from the host system. It also had a feature to switch shell if it found a better one (preferring busybox and its internal tools).

    Yeah… It was tedious process. It was one of those “I’ll write a simple script. So simple that it’ll work on almost every posixy shell.”… rest is history.


  • Zucca@sopuli.xyztoLinux@lemmy.mlbash coding standards?
    link
    fedilink
    arrow-up
    5
    ·
    edit-2
    4 months ago

    I would then assume those scripts weren’t written properly to begin with.

    But yes, shell scripts should be used (normally) to automate some simple tasks (file copying, backups…) or as an wrapper to exec some other program. I’ve written several shell scripts to automate things on my personal machines.

    However shell script can be complex program while at the same time being (somewhat) easy to maintain:

    • functions, use functions, alot
      • comment every function and describe what it expects in stdin or as an arguments
      • also comment what it outputs or sets

    This way at least I don’t break my scripts, when I need to modify a function or some way extend my scripts. Keeping the UNIX philosophy inside shell scripts: let one function do one thing well.

    And of course: YMMV. People have wastly different coding standards when it comes to personal little(?) projects.


    • utilize awk if you need to process (=more complex than just grepping) large amounts of text.
      • make your awk code conform to at least busybox awk for compability

    I once did a sh script that needed (because I wanted a challenge?) to be compatible with vanilla Android shell too. So I needed to test it with regular bash, busybox and mksh+toybox. That was ‘fun’.

    I’ve had some initial plans to spllit the code out from that project and develop a “shell” library that would ease building shell scripts that are compatible with different systems… But I bet someone else has already done that.












  • Zucca@sopuli.xyztoLinux@lemmy.mlSystemd Looks to Replace sudo with run0
    link
    fedilink
    English
    arrow-up
    11
    arrow-down
    1
    ·
    6 months ago

    sudo is a setuid binary, but it’s a fairly simple program

    Some people would disagree to this.

    The brief description of run0 already has too many potential points of failure.

    If the “listener” is PID1, which will run the privileged command, in theory, it would be quite bullet proof (in a working system PID1 is always there). But since this is systemd, PID1 is much more than that and much more complex. On the other hand spawning another daemon from PID1 to be the “listener” makes it, perhaps, even more complicated. You’d have to make sure the listener is always running and have some process supervisor there to watch if it exits… and maybe even a watchdog polling it to make sure it isn’t frozen.

    So my conclusion is the same as yours:

    a solution in search of a problem

    We already have a working solution. Have a well written SUID program. I’ve been using doas for some years now. It’s simple enough that I trust it.