• MercuryGenisus@lemmy.world
    link
    fedilink
    arrow-up
    182
    arrow-down
    2
    ·
    edit-2
    3 days ago

    I would reject this pull request. Why is the indenting all over the place? Why is your keyword capitalisation all over the place? WHY YELLOW?!

    Edit: the more I look at this the more it pisses me off. Wtf is going on with your kerning? Just random number and placement of spaces. Also, why is the table name in caps? Who does that? Select * is lazy. Do you really need every field about a girl? Really? Worst of all, not a limited request. I sware this is just the kind of thing that would return 30 million rows and brick the database for twenty seconds.

    • somnuz@lemm.ee
      cake
      link
      fedilink
      arrow-up
      34
      ·
      3 days ago

      You are now a Certified Rejector. Stay sharp, keep the wheel rolling.

    • Black616Angel@discuss.tchncs.de
      link
      fedilink
      arrow-up
      4
      ·
      2 days ago

      You forgot some: Why is there no space after SELECT?

      Why are boyfriend and smallwaist not questions like is_cute and is_crazy? Either all boils are with a verb or none.

      Also why is smallwaist not in snake case? It should be small_waist (or better yet has_small_waist or even better waist = “small”)

      Also also boyfriend should be null not false, this would solve multiple issues.

      And finally the only positive thing is the * itself, because selecting only body would be even worse. 🤣

        • lennivelkant@discuss.tchncs.de
          link
          fedilink
          arrow-up
          1
          ·
          2 days ago

          That’s (part of) why it should be a separate table to map the relation “Relationship”. People can have more than one (polyamory, infidelity), and you could track fields like the start, end, status (e.g. flirting, dating, committed, engaged, married, ended) in there.